On Fri, 26 Jun 2015 23:10:43 +0200
Michael Niedermayer <michae...@gmx.at> wrote:
> On Fri, Jun 26, 2015 at 08:45:09AM -0700, Philip Langdale wrote:
> > This HWAccel isn't really usable right now due to an nvidia driver
> > bug, so we don't want it selected by default.
> >
> > HWAccels have a capabilities field and there's a comment about
> > flags, but no flags exist today, so let's add one for experimental
> > hwaccels.
> >
> > Signed-off-by: Philip Langdale <phil...@overt.org>
> > ---
> > libavcodec/avcodec.h | 8 +++++++-
> > libavcodec/utils.c | 7 +++++++
> > libavcodec/vdpau_hevc.c | 1 +
> > libavcodec/version.h | 2 +-
> > 4 files changed, 16 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index 761d3c1..ddbf0a3 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -894,6 +894,12 @@ typedef struct RcOverride{
> > */
> > #define CODEC_CAP_LOSSLESS 0x80000000
> >
> > +/**
> > + * HWAccel is experimental and is thus avoided in favor of non
> > experimental
> > + * codecs
> > + */
> > +#define HWACCEL_CODEC_CAP_EXPERIMENTAL 0x0200
>
> this should have a AV prefix if it is public API
>
> if instead its left as private API then the version change should be
> micro only
>
> i dont know which way makes more sense
>
> patch LGTM either way
>
> [...]
Pushed with a micro bump. As this isn't a feature that's been used
before, we can decide it should be promoted to public at some future
time. It would be hard to do the opposite.
Thanks,
--phil
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
