On 27-Jun-2015 12:36 AM, "Philip Langdale" <phil...@overt.org> wrote: > > On 2015-06-26 09:48, Niklesh Lalwani wrote: >> >> The output produced here was actually different from the expected. Hence >> the test failed. I produced ASS file for both the original file and the >> encoded file. The ass file produced from the encoded mp4 file seemed to be >> dropping all text after \N >> After a lot of digging, I found out that while appending '\n' into the >> buffer in encoding, it is to be considered as a single character and not 2. >> Making this change in movtextenc.c solved the issue and now I have matching >> ASS outputs for both the files. >> However, the test still fails even though I have exact same ASS files. >> PS - there is no style information associated here as far as I can see. >> Please correct me if I'm going wrong here. > > > This test produces another mp4 file - not just an ASS subtitle (which is > what the other movtextenc test does. So something else you've done has > altered the output - perhaps through metadata or adding a box that wasn't > there before, etc. >
You are right. My movenc.c file was different ( I didn't undo the commit to set the subtitle dimensions in my working branch which I submitted here some time back) Got the latest movenc.c file from git, and the test doesn't give any errors now ( after making the change in movtextenc.c which I mentioned before) Updated patch attached. Thanks, Niklesh
0001-movtextenc.c-Support-for-Bold-Italic-and-Underlined-.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
