> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of Samuel
> Raposo Vieira Mira
> Sent: 2023年5月17日 0:16
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec: Add VP8 encoder
>
> > > Connected FFmpeg to Mediacodec VP8 encoder.
> > > Minor Version bump.
> > ---
> > > configure | 1 +
> > > libavcodec/Makefile | 1 +
> > > libavcodec/allcodecs.c | 1 +
> > > libavcodec/mediacodec_wrapper.c | 4 ++++
> > > libavcodec/mediacodecenc.c | 29 +++++++++++++++++++++++++++++
> > > libavcodec/version.h | 2 +-
> > > 6 files changed, 37 insertions(+), 1 deletion(-)
> >
> > The patch file format is broken (missing a space before unchanged lines).
> > Please send it via git send-email or add the patch as attachment.
>
> Thanks for noticing the issue! will send as patch next time.
>
> > >
> > > @@ -387,6 +389,8 @@ int
> > > ff_AMediaCodecProfile_getProfileFromAVCodecContext(AVCodecContext *avctx)
> > > case FF_PROFILE_HEVC_MAIN_10:
> > > return HEVCProfileMain10;
> > > }
> > > + } else if (avctx->codec_id == AV_CODEC_ID_VP8) {
> > > + return VP8ProfileMain;
> > > } else if (avctx->codec_id == AV_CODEC_ID_VP9) {
> > > switch (avctx->profile) {
> > > case FF_PROFILE_VP9_0:
> >
> > The function is a map from avctx->profile to MediaCodec profile.
> > It's not supposed to select a default profile.
>
> But there is no avctx->profile for VP8.
> Should I create an FF_PROFILE_VP8?
Since there is only one profile and unlikely to change in the future, it seems
profile
is useless for VP8 decoder and encoder. I think we can just ignore/skip it for
VP8.
>
>
> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> on behalf of Zhao Zhili
> <quinkbl...@foxmail.com>
> Date: Sunday, 7. May 2023 at 11.26
> To: Samuel Raposo Vieira Mira <samuel.m...@qt.io>, FFmpeg development
> discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec: Add VP8 encoder
> On Fri, 2023-04-28 at 11:07 +0000, Samuel Raposo Vieira Mira wrote:
> > Connected FFmpeg to Mediacodec VP8 encoder.
> > Minor Version bump.
> > ---
> > configure | 1 +
> > libavcodec/Makefile | 1 +
> > libavcodec/allcodecs.c | 1 +
> > libavcodec/mediacodec_wrapper.c | 4 ++++
> > libavcodec/mediacodecenc.c | 29 +++++++++++++++++++++++++++++
> > libavcodec/version.h | 2 +-
> > 6 files changed, 37 insertions(+), 1 deletion(-)
>
> The patch file format is broken (missing a space before unchanged lines).
> Please send it via git send-email or add the patch as attachment.
>
> >
> > @@ -387,6 +389,8 @@ int
> > ff_AMediaCodecProfile_getProfileFromAVCodecContext(AVCodecContext *avctx)
> > case FF_PROFILE_HEVC_MAIN_10:
> > return HEVCProfileMain10;
> > }
> > + } else if (avctx->codec_id == AV_CODEC_ID_VP8) {
> > + return VP8ProfileMain;
> > } else if (avctx->codec_id == AV_CODEC_ID_VP9) {
> > switch (avctx->profile) {
> > case FF_PROFILE_VP9_0:
>
> The function is a map from avctx->profile to MediaCodec profile.
> It's not supposed to select a default profile.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
