On Fri, Jun 26, 2015 at 12:05:09AM +0200, Andreas Cadhalpun wrote: > If 'buf_size * 8' is smaller than 'avctx->channels * > (avctx->bits_per_raw_sample + 4)' it resulted in a division by zero. > > Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> > --- > libavcodec/s302m.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/s302m.c b/libavcodec/s302m.c > index 5cf9eb5..36c8e7c 100644 > --- a/libavcodec/s302m.c > +++ b/libavcodec/s302m.c > @@ -86,9 +86,9 @@ static int s302m_parse_frame_header(AVCodecContext *avctx, > const uint8_t *buf, > avctx->channel_layout = AV_CH_LAYOUT_5POINT1_BACK | > AV_CH_LAYOUT_STEREO_DOWNMIX; > } > avctx->bit_rate = 48000 * avctx->channels * > (avctx->bits_per_raw_sample + 4) + > - 32 * (48000 / (buf_size * 8 / > - (avctx->channels * > - (avctx->bits_per_raw_sample + 4)))); > + 32 * (48000 * avctx->channels > + * (avctx->bits_per_raw_sample + 4)) > + / (buf_size * 8);
i dont think the new code matches the nb_samples vs. buf_size vs. samplerate of s302m_decode_frame() maybe the nb_samples calculation could be factored out and used for bitrate computation too [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel