On Thu, May 11, 2023 at 11:32 AM Lynne <d...@lynne.ee> wrote: > > May 11, 2023, 10:39 by ffm...@haasn.xyz: > > > From: Niklas Haas <g...@haasn.dev> > > > > Recent versions of libplacebo have required Vulkan versions incompatible > > with lavu Vulkan hwcontexts. While this is expected to change > > eventually, breaking vf_libplacebo every time there is such a transition > > period is obviously undesired behavior, as the following sea of bug > > reports shows. > > > > This commit adds a fallback path for pl_vulkan_import failures which > > simply creates an internal device instead. Also useful when no interop > > with lavu vulkan hwframes is needed or desired. > > > > Fixes: https://github.com/haasn/libplacebo/issues/170 > > Fixes: https://github.com/mpv-player/mpv/issues/9589#issuecomment-1535432185 > > Fixes: https://code.videolan.org/videolan/libplacebo/-/issues/270 > > > > NAK. The whole point of the hwcontext infrastructure is to be > explicit, and creating a new device behind the scenes is anything but that. > >
This is not a native vulkan filter, it is an external library not married to our vulkan infrastructure - it merely has compatibility for it. Ensuring it works, as it might have separate requirements or a different development cycle, is hardly a bad thing. And it greatly simplifies the usability for users that only want a quick GPU processing. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
