Thank you, Martin.
It's my mistake that delete an empty line in the end of file.
Should I submit a patch with a newline in the end of file or do something else?
Thanks for your review and point out the details of error.
------------------ Original ------------------
From:
"Martin Storsj?1?7"
<mar...@martin.st>;
Date: Fri, Apr 14, 2023 08:20 PM
To: "FFmpeg development discussions and
patches"<ffmpeg-devel@ffmpeg.org>;
Cc: "??????"<839789...@qq.com>;
Subject: Re: [FFmpeg-devel] [PATCH] codec/aarch64/hevc: add
transform_luma_neon
On Thu, 13 Apr 2023, xufuji456 wrote:
> got 56% speed up (run_count=1000, CPU=Cortex A53)
> transform_4x4_luma_neon: 45 transform_4x4_luma_c: 103
>
> Signed-off-by: xufuji456 <839789...@qq.com>
> ---
> libavcodec/aarch64/hevcdsp_idct_neon.S | 48
+++++++++++++++++++++++
> libavcodec/aarch64/hevcdsp_init_aarch64.c | 2 +
> 2 files changed, 50 insertions(+)
Thanks, this version can be applied - and still looks good, so I pushed
it.
I see that you fixed the issue by just applying the new code in the middle
of the file instead of at the end of the file though. You really should
try to look into what it is that is causing the previous version of the
file to be lacking the trailing newline, since that's not what is in the
actual upstream git. So it looks like there's something off with your git
workflow, and it would be very good to get that sorted out before going
forward anyway.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
