Quoting Nicolas George (2023-04-29 10:46:31) > Nicolas George (12023-04-28): > > And during the work of turning all into threads, opportunities to split > > the structure in more logical ways with less code noise will almost > > certainly present themselves. > > I had intended to not reply further on this, but I just had a severe > case of esprit de l'ecalier, so I just add this: > > For example, it is entirely possible that a lot of these “private” > fields could become local variables and functions parameters in the > threads. That would be elegant and efficient. > > But now we will never know, because they will all be stuffed in a > private context, according to “good practices”, and that will spare the > effort of checking what their exact scope is.
That does not follow at all - just because something was moved once does not mean it cannot be moved again if a better place is found later. This change is an incremental improvement, I am not claiming it is the best possible shape this code could ever have. In my experience, it is much better to have a series of actually performed incremental improvements, than to bikeshed endlessly about what the perfect final endstate should be and never get anything done. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
