On Mon, 24 Apr 2023 17:56:38 +0200 Lynne <d...@lynne.ee> wrote: > This is part two of the vulkan patchset, which contains all the > hwcontext and vulkan.c rewrites, and filtering changes. > > 55 patches attached.
The new Vulkan code looks like a clear improvement over the status quo to me. I tested it locally and everything works as expected. The new synchronization code LGTM overall. As noted over IRC I think it specifies unnecessarily strict execution/memory dependencies, though I think it's better to merge a working state first than to play the microoptimization game at this stage. (It's also worth noting that this code is still significantly slower than vf_libplacebo's native hwupload/hwdownload primitives, for as-of-yet-to-be-determined reasons) That said, I'm still in favor of this subset of your patchset being merged soon, since it fixes major issues that prevent the current Vulkan code on master from working properly with mpv/libplacebo. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
