Quoting p...@sandflow.com (2023-04-26 19:53:01)
> From: Pierre-Anthony Lemieux <p...@palemieux.com>
>
> ---
> libavformat/imf_cpl.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
> index ad84a68b13..a7cf5fa360 100644
> --- a/libavformat/imf_cpl.c
> +++ b/libavformat/imf_cpl.c
> @@ -608,11 +608,10 @@ static int push_main_audio_sequence(xmlNodePtr
> audio_sequence_elem, FFIMFCPL *cp
> ret = fill_trackfile_resource(resource_elem,
> &vt->resources[vt->resource_count],
> cpl);
> - vt->resource_count++;
> - if (ret) {
> + if (ret)
> av_log(NULL, AV_LOG_ERROR, "Invalid Resource\n");
> - continue;
Should an error here not propagate to the caller?
Unrelated, but all this logging to NULL is very evil.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
