On 3/11/23 17:14, Thomas Mundt wrote:

+    %if mmsize == 32
+        vpbroadcastd m12, DWORD clip_maxm


I get a green pattern at bit depths > 8.
Looks good with:
vpbroadcastw m12, WORD clip_maxm

+    %else
      movd        m12, DWORD clip_maxm
      SPLATW      m12, m12, 0
+    %endif

Of course it should be a word broadcast!

But why doesn't my checkasm test catch it?

              bwdif->filter_line = ff_bwdif_filter_line_sse2;
          if (EXTERNAL_SSSE3(cpu_flags))
              bwdif->filter_line = ff_bwdif_filter_line_ssse3;
+        if (ARCH_X86_64 && EXTERNAL_AVX2(cpu_flags))
+            bwdif->filter_line = ff_bwdif_filter_line_avx2;
      } else if (bit_depth <= 12) {
          if (EXTERNAL_SSE2(cpu_flags))
              bwdif->filter_line = ff_bwdif_filter_line_12bit_sse2;
          if (EXTERNAL_SSSE3(cpu_flags))
              bwdif->filter_line = ff_bwdif_filter_line_12bit_ssse3;
+        if (ARCH_X86_64 && EXTERNAL_AVX2(cpu_flags))
+            bwdif->filter_line = ff_bwdif_filter_line_12bit_avx2;
      }
  }

I was intending to only modify/write the 8-bit function so this is a mistake.

Thanks.  I'll be back with a version 2.

[re-sending to list]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to