Quoting Zhao Zhili (2023-03-10 15:44:56)
>
> > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of Anton
> > Khirnov
> > Sent: 2023年3月10日 21:46
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: avoid invalid
> > reads in forced keyframe parsing
> >
> > Fixes #10243
> > ---
> > fftools/ffmpeg_mux_init.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
> > index b3cc502fdd..09d24ba8e5 100644
> > --- a/fftools/ffmpeg_mux_init.c
> > +++ b/fftools/ffmpeg_mux_init.c
> > @@ -2063,7 +2063,7 @@ static void parse_forced_key_frames(KeyframeForceCtx
> > *kf, const Muxer *mux,
> > if (next)
> > *next++ = 0;
> >
> > - if (!memcmp(p, "chapters", 8)) {
> > + if (strstr(p, "chapters") == p) {
>
> Does strncmp() more efficient in this case?
I don't see the point of optimizing this code for speed. A strncmp call
is longer and less readable IMO.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
