On 3/2/23 13:57, James Almer wrote: > > The SEI for HEVC does keep the country code in the payload, but not AV1. > Are you sure about HEVC? I just checked a sample and trace_headers > reported this: > > [trace_headers] Prefix Supplemental Enhancement Information > [trace_headers] 0 forbidden_zero_bit 0 = 0 > [trace_headers] 1 nal_unit_type 100111 = 39 > [trace_headers] 7 nuh_layer_id 000000 = 0 > [trace_headers] 13 nuh_temporal_id_plus1 001 = 1 > [trace_headers] 16 last_payload_type_byte 00000100 = 4 > [trace_headers] 24 last_payload_size_byte 01000000 = 64 > [trace_headers] User Data Registered ITU-T T.35 > [trace_headers] 32 itu_t_t35_country_code 10110101 = 181 > [trace_headers] 40 itu_t_t35_payload_byte[1] 00000000 = 0 > [trace_headers] 48 itu_t_t35_payload_byte[2] 00111100 = 60 > [trace_headers] 56 itu_t_t35_payload_byte[3] 00000000 = 0 > [trace_headers] 64 itu_t_t35_payload_byte[4] 00000001 = 1 > [trace_headers] 72 itu_t_t35_payload_byte[5] 00000100 = 4 > [trace_headers] 80 itu_t_t35_payload_byte[6] 00000001 = 1 > > Which is in line with section 8.3.1 of ITU-T Rec. H.274 as well as > section D.2.6 of ITU-T Rec. H.265. > > So i think this function should not set the country code at all as part > of the payload, and start with itu_t_t35_terminal_provider_code.
OK, I will make that change since both HEVC and AV1 implementations seem to match. Thanks Raphaël Zumer _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
