Other issues have been modified. The following three issues have not been
modified. I have explained them:
>> @@ -215,13 +249,13 @@ static void prepare_app_arguments(int *argc_ptr, char
>> ***argv_ptr)
>> if (win32_argv_utf8) {
>> *argc_ptr = win32_argc;
>> *argv_ptr = win32_argv_utf8;
>> - return;
>> + goto end;
> We only use goto for error processing.
I think that it's more concise to use code this way.
>> + int i, j;
>> + for (i = 1; i < argc; i++) {
>> + char *match = strstr(argv[i], "://");
>> + if (match) {
>> + int total = strlen(argv[i]);
>> + for (j = 0; j < total; j++) {
>> + argv[i][j] = '*';
>> + }
>Masking the whole URL seems too much. Logins and passwords are introduced by
>the @ character.
I think that it would be better to replace the entire url, so that the code
implementation is simple.
>> + char **argv2;
>> + argv2 = av_mallocz(argc * sizeof(char *));
>sizeof(*argv2)
>
>> + maskFlag = 0;
>> + if (argc > 1 && !strcmp(argv[1], "-mask_url")) {
>> + argv[1] = argv[0];
>> + maskFlag = 1;
>> + argc--;
>> + argv++;
>> + }
>This option is not special nor important enough to warrant a special treatment
>like that.
This option needs to replace the URL. It is more appropriate to judge mask_url
and copy argv in this place.
If you think my idea is wrong, please give your specific advice,
thank you, Nicolas George.
-----邮件原件-----
发件人: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] 代表 Nicolas George
发送时间: 2022年12月23日 17:13
收件人: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
抄送: wangqinghua (I) <wangqingh...@huawei.com>
主题: Re: [FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils:add
-mask_url to replace the protocol address in the command with the asterisk (*)
Wujian(Chin) (12022-12-23):
> I've modified most of the issues, and I've explained some of the issues that
> don't.
> If you don't accept my explanation, do you have any other better suggestions
> and methods?
I have already made a more detailed comment in the first thread.
--
Nicolas George
_______________________________________________
ffmpeg-user mailing list
ffmpeg-u...@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-user
To unsubscribe, visit link above, or email ffmpeg-user-requ...@ffmpeg.org with
subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
