On Sun, Nov 06, 2022 at 08:19:24AM -0500, Ronald S. Bultje wrote: > Hi, > > On Sat, Nov 5, 2022 at 2:54 PM Clément Bœsch <u...@pkh.me> wrote: > > > On Sat, Nov 05, 2022 at 04:44:39PM +0100, Paul B Mahol wrote: > > [...] > > > > Finally, I do believe a lot of other color filters could at least > > benefit > > > > from > > > > fixing their gamma handling (I know I'm guilty of this in various other > > > > filters). > > > > > > gamma handling depends not on pixel format but on metadata present in > > frame. > > > > Right, as suggested by Ronald on IRC, maybe it would have been appropriate > > to use the vf colorspace code to honor the transfer functions. > > > > That being said, this involves quite a substantial refactoring. Is this > > considered blocking? > > > > Not for me. I'd like a big fat FIXME and I (or you, or anyone) can look > into this at some point in the future. >
I will likely add a warning, or even error out if the input is not sRGB to limit the damage. -- Clément B. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
