On Mon, Jun 08, 2015 at 03:33:07AM +0200, Max Pole wrote: > > > > > > > I've recently got a couple of appropriate samples from the PPSSPP > > emulator > > > project so I coud test this feature extensively. > > > > where can i find these samples ? > > are they online somewhere? can you upload them ? > > > > I've just uploaded a folder named "atrac3p GHA phase inversion" to > upload.ffmpeg.org/incoming. Hopefully, it does contain everything you need. > > > > > > > Do we need to update FATE tests to include a test for this feature? > > > > a fate test might be interresting if its possible/reliable and > > not too hard to implement > > > > Unfortunately, I don't have no idea how to make FATE tests myself so any > help would be very appreciated!
its probably not so important to make a fate test for this also atrac3p uses floats so there could be rounding issues that make this a bit harder if you want to try anyway, look at commits which added fate tests for other decoders. Also ideally we would like to avoid having to add a wav pcm reference to the fate samples, so hopefully one of the samples decodes bit identical between platforms (i can test a few if someone posts a patch adding a fate test) [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
