Hi Anton, Thank you for comment. After double checked the OpenVINO, it is true that the code would corrupt if the binary file does not exist. We would have nothing to do in this case, that's why I code to check the file existence explicitly. Yes, you are right, it is not a proper way to do like this. But I have no idea how to solve it more decently, since trying to open it as you mentioned would lead to crush immediately. Maybe there is some solution I don’t know, any further input would be appreciated. 😊
PS, it is not a good commit message since I have not fixed this issue, it's just a workaround. I would modify it in next version. Thank you, Ting FU > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of Anton > Khirnov > Sent: Thursday, August 4, 2022 06:40 PM > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] lavfi/dnn: Fix OpenVINO missing model file > corrupt issue. > > Quoting Ting Fu (2022-08-04 11:31:01) > > DNN OpenVINO backend would not report missing model file if it does > > not exist. It would corrupt directly with out any error infomation. > > This commit > > "corrupt"? > > The patch looks completely wrong. Testing for file existence explicitly is > known > to be a bad pattern that leads to all kinds of races, security issues, and > other > bugs. Just trying to open the file and returning an error if that fails is > the right > thing to do. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
