Quoting Michael Niedermayer (2022-07-30 19:12:39) > On Sat, Jul 30, 2022 at 11:55:45AM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > On Wed, Jul 27, 2022 at 12:08:09AM +0200, Andreas Rheinhardt wrote: > > >> Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@outlook.com> > > >> --- > > >> libavcodec/arm/mpegvideoencdsp_init_arm.c | 4 ++-- > > >> libavcodec/mips/h263dsp_mips.h | 2 +- > > >> libavcodec/mips/mpegvideoencdsp_msa.c | 4 ++-- > > >> libavcodec/mpegvideoencdsp.c | 10 +++++----- > > >> libavcodec/mpegvideoencdsp.h | 10 +++++----- > > >> libavcodec/ppc/mpegvideoencdsp.c | 8 ++++---- > > >> libavcodec/x86/mpegvideoenc_qns_template.c | 4 ++-- > > >> libavcodec/x86/mpegvideoencdsp.asm | 4 ++-- > > >> libavcodec/x86/mpegvideoencdsp_init.c | 6 +++--- > > >> 9 files changed, 26 insertions(+), 26 deletions(-) > > > > > > LGTM, also all similar things should be ok > > > > > > [...] > > > > > > > Unfortunately, it is not so easy. The first version of this patchset > > (this here) forgot to update the definitions of several loongarch > > functions, leading to lots of red on patchwork. The second version fixed > > the compilation error, but forgot some constifications due to > > unfortunate oversights. For the third version, I wanted to actually > > compile loongarch instead of just staring at the code; but the > > GCC-cross-compiler does not seem to support lsx and lasx (and looking at > > the loongarch-code in GCC makes me believe that they are just not > > supported (yet)). Therefore I resorted to creating dummy-functions for > > all the __lasx_* and __lsx_* functions (they show no more > > const-warnings). I wanted to let the FATE-loongarch-box test this once > > more (and tell me whether there are still any issues left), yet this box > > is no longer active since a few days (for reasons unknown). Can you > > compile the lsx and lasx code (after all, you committed all the > > loongarch code)? > > i have no easy way to test loongarch, what i can test is qemu-mips. > i think i have said that a few times already. > > I do have a loongson box that is IIRC ready to be shipped (within EU) to > whoever volunteers to maintain that box for FFmpeg. I dont know if that > box would help with the current code. The OS will liklely need to be updated > and IIRC this has no normal update mechanism) I didnt touch this box for a > really long time.
What OS is it? I could conceivably host such a machine and give other devs SSH access to it, if it does not require too much maintenance and/or electricity. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
