On Mon, 2022-07-25 at 01:21 +0000, Xiang, Haihao wrote: > On Fri, 2022-07-22 at 11:06 -0700, Dmitry Rogozhkin wrote: > > GPU hang is one of the most typical errors on Intel GPUs in > > case something goes wrong. It's important to recognize it > > explicitly for easier bugs triage. Also, this error code > > can be used to trigger GPU recovery path in self-written > > applications. > > > > Signed-off-by: Hon Wai Chow <hon.wai.c...@intel.com> > > Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozh...@intel.com> > > --- > > libavcodec/qsv.c | 1 + > > libavfilter/qsvvpp.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c > > index 385b43b..55bcb6e 100644 > > --- a/libavcodec/qsv.c > > +++ b/libavcodec/qsv.c > > @@ -125,6 +125,7 @@ static const struct { > > { MFX_ERR_INVALID_VIDEO_PARAM, AVERROR(EINVAL), "invalid > > video > > parameters" }, > > { > > MFX_ERR_UNDEFINED_BEHAVIOR, AVERROR_BUG, "undefined > > behavior" }, > > { MFX_ERR_DEVICE_FAILED, AVERROR(EIO), "device > > failed" }, > > + { MFX_ERR_GPU_HANG, AVERROR(EIO), "GPU > > Hang" }, > > { MFX_ERR_INCOMPATIBLE_AUDIO_PARAM, AVERROR(EINVAL), > > "incompatible audio > > parameters" }, > > { MFX_ERR_INVALID_AUDIO_PARAM, AVERROR(EINVAL), "invalid > > audio > > parameters" }, > > > > diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c > > index 954f882..7504906 100644 > > --- a/libavfilter/qsvvpp.c > > +++ b/libavfilter/qsvvpp.c > > @@ -100,6 +100,7 @@ static const struct { > > { MFX_ERR_INVALID_VIDEO_PARAM, AVERROR(EINVAL), "invalid > > video > > parameters" }, > > { > > MFX_ERR_UNDEFINED_BEHAVIOR, AVERROR_BUG, "undefined > > behavior" }, > > { MFX_ERR_DEVICE_FAILED, AVERROR(EIO), "device > > failed" }, > > + { MFX_ERR_GPU_HANG, AVERROR(EIO), "GPU > > Hang" }, > > { MFX_ERR_INCOMPATIBLE_AUDIO_PARAM, AVERROR(EINVAL), > > "incompatible audio > > parameters" }, > > { MFX_ERR_INVALID_AUDIO_PARAM, AVERROR(EINVAL), "invalid > > audio > > parameters" }, > > > > Could you add other missing qsv video errors or warnings too ? Yes, sure. For what I see we are missing 3 statuses returnable by mediasdk library implementations: MFX_ERR_GPU_HANG, MFX_ERR_NONE_PARTIAL_OUTPUT, MFX_ERR_REALLOC_SURFACE. Other statuses defined in mfxdefs.h are not returnable to ffmpeg level (they are internal or plugin specific stuff). I will resubmit the patch under other name with added stuff. > > Thanks > Haihao > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".