On 5 Jul 2022, at 2:11, Niklas Haas wrote: > From: Niklas Haas <g...@haasn.dev> > > This header is unconditionally installed, even though the utility > functions defined by it may be missing from the built library. > > A precedent set by e.g. libavcodec/qsv.h (and others) is to always > provide these functions by compiling stub functions in the absence of > CONFIG_*. Make hwcontext_vulkan.h match this convention. > > Fixes downstream issues, e.g. > https://github.com/haasn/libplacebo/issues/120 > > Signed-off-by: Niklas Haas <g...@haasn.dev> > --- > libavutil/Makefile | 2 +- > libavutil/hwcontext_vulkan.c | 26 ++++++++++++++++++++++++-- > 2 files changed, 25 insertions(+), 3 deletions(-) > > [...]
Public API symbols (av_*) shouldn't completely disappear based on configure options. LGTM. -- J. Dekker _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".