lör 2022-06-18 klockan 16:57 +0200 skrev Anton Khirnov: > Quoting Tomas Härdin (2022-06-16 14:44:45) > > ons 2022-06-15 klockan 09:15 -0300 skrev James Almer: > > > On 6/15/2022 6:59 AM, Tomas Härdin wrote: > > > > tis 2022-06-14 klockan 22:26 +0200 skrev Michael Niedermayer: > > > > > On Tue, Jun 14, 2022 at 04:42:06PM +0200, Tomas Härdin wrote: > > > > > > Left this as an ff_ funtion for now since it's only used by > > > > > > the > > > > > > j2k > > > > > > code > > > > > > > > > > > > /Tomas > > > > > > > > > > > mem.c | 24 ++++++++++++++++++++++++ > > > > > > mem.h | 55 > > > > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > > > > 2 files changed, 79 insertions(+) > > > > > > 21be65bd06e3260f9f36598d5d574ee32e7131a6 0006-lavu-mem- > > > > > > Add- > > > > > > ff_fast_recalloc.patch > > > > > > From 5d36d431ffe4c8ba0f698d0c288ebc16b83f0bbc Mon Sep 17 > > > > > > 00:00:00 > > > > > > 2001 > > > > > > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <g...@haerdin.se> > > > > > > Date: Tue, 14 Jun 2022 13:35:18 +0200 > > > > > > Subject: [PATCH 06/13] lavu/mem: Add ff_fast_recalloc() > > > > > > > > > > You cannot call a ff_* function thats in libavutil from > > > > > outside > > > > > libavutil > > > > > this will fail with shared libs as the ff* stuff is not > > > > > exported > > > > > > > > Ah, I suspected as much. Would there be much opposition to a > > > > public > > > > function like this in lavu? I could just keep it local to the > > > > j2k > > > > code > > > > > > Just make it public by using the av_ prefix (You in fact added it > > > to > > > mem.h, which is installed. You'd need to add it to mem_internal.h > > > if > > > you > > > wanted to avoid exposing it). > > > > Ah I didn't notice it existed. But it doesn't look like the right > > place > > for it either, it's just a bunch of macros in there. > > > > > Don't forget to add an APIChanges entry and minor lavu version > > > bump > > > before you push if you do. > > > > Right. Unless people have objections to the name or something > > similar. > > I kinda want the functions in mem.h to have a better naming > > system.. > > Yeah, I really dislike those random-endian av_fast_<do_thing>_maybe() > kinds names. > Maybe something like av_*alloc_reuse()? >
I see the suffix p on functions that take pointer-to-pointer, like av_reallocp(). But not on all of them - av_fast_malloc() should've been called av_fast_mallocp() imo /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
