Hi,
movdqa in ff_yuv2yuvX_sse3() expects a 16-byte alignment according to its
documentation causing segfaults in fate-checkasm-sw_scale.
-Thilo
From ed84410b2371a758dad03d3830bfb4f3d86cd4ed Mon Sep 17 00:00:00 2001
From: Michael Goulet <mgou...@fb.com>
Date: Thu, 16 Jun 2022 10:14:50 +0200
Subject: [PATCH] tests/checkasm/sw_scale: Fix alignment for movdqa
SSE3 instruction movdqa in ff_yuv2yuvX_sse3() expects a 16-byte aligned address
for a memory address, or else a segfault is generated.
The src_pixels buffer below was not aligned to 16 bytes on the stack
necessarily, so we got segfaults during fate-checkasm-sw_scale.
Therefore 16-byte align all of these local variables, aligning them too much
shouldn't hurt.
---
tests/checkasm/sw_scale.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c
index 31d9a525e9..b643a47c30 100644
--- a/tests/checkasm/sw_scale.c
+++ b/tests/checkasm/sw_scale.c
@@ -75,11 +75,11 @@ static void check_yuv2yuvX(void)
int dstW, const uint8_t *dither, int offset);
const int16_t **src;
- LOCAL_ALIGNED_8(int16_t, src_pixels, [LARGEST_FILTER *
LARGEST_INPUT_SIZE]);
- LOCAL_ALIGNED_8(int16_t, filter_coeff, [LARGEST_FILTER]);
- LOCAL_ALIGNED_8(uint8_t, dst0, [LARGEST_INPUT_SIZE]);
- LOCAL_ALIGNED_8(uint8_t, dst1, [LARGEST_INPUT_SIZE]);
- LOCAL_ALIGNED_8(uint8_t, dither, [LARGEST_INPUT_SIZE]);
+ LOCAL_ALIGNED_16(int16_t, src_pixels, [LARGEST_FILTER *
LARGEST_INPUT_SIZE]);
+ LOCAL_ALIGNED_16(int16_t, filter_coeff, [LARGEST_FILTER]);
+ LOCAL_ALIGNED_16(uint8_t, dst0, [LARGEST_INPUT_SIZE]);
+ LOCAL_ALIGNED_16(uint8_t, dst1, [LARGEST_INPUT_SIZE]);
+ LOCAL_ALIGNED_16(uint8_t, dither, [LARGEST_INPUT_SIZE]);
union VFilterData{
const int16_t *src;
uint16_t coeff[8];
--
2.20.1 (Apple Git-117)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
