On Mon, May 30, 2022 at 10:35 AM Soft Works <softwo...@hotmail.com> wrote:
> > > > -----Original Message----- > > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of > > Anton Khirnov > > Sent: Monday, May 30, 2022 9:35 AM > > To: FFmpeg development discussions and patches <ffmpeg- > > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem > > alignment for vsynth..mpeg2-422 tests > > > > Quoting Soft Works (2022-05-28 15:17:54) > > > Do you have a better idea? > > > > > > The one advantage of this method is that you don’t need to change > > compilation parameters > > > nor any source code. It’s only a runtime flag being set only for > > this specific family of tests. > > > > At the very least, I would expect the commit message to explain what > > exactly the problem is, and why is it fixed in this seemingly ad-hoc > > manner. > > > > "limit mem alignment to fix failing tests" explains nothing. > > BTW, that's not the actual commit message. > What I have submitted is this: > > ------------------------ > > tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests > > The tests: > > - vsynth2-mpeg2-422 > - vsynth1-mpeg2-422 > - vsynth_lena-mpeg2-422 > > were failing on newer CPUs where av_cpu_max_align() returns > values > 32. This patch sets cpuflags to disable avx512 > extensions for those tests only. > > Signed-off-by: softworkz <softwo...@hotmail.com> > > ------------------------ > > What do you want me to add to it? > > There appears a very large language barrier present here. In that FATE thread I explicitly wrote that this or similar solutions are considered the hack. sw > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
