It appears a consensus has been reached that this api should be public with av_ instead of avpriv_, and that AVRationals work better here than floating points. As a result, I've unmarked it as [WIP].
Changes in v5: - Unmark as [WIP], ready for review and merging - rename public functions to namespace them via av_csp_, as requested by Anton K - documented public API using Doxygen comments - remove abs() from denominator in abs_sub_q, assuming denom is positive, as requested by Andreas R Changes in v4: - Provide the patch with an AVCIExy struct so we can discuss its potential pros and cons Changes in v3: - increase precision for AVR() macro to 100k, at haasn's request - add #define AVUTIL_CSP_DENOM 100000 - add 0.5 to the AVR macro definition to get exact values from truncation Leo Izen (1): avutil/csp: create public API for colorspace structs libavfilter/colorspace.c | 143 ++++++++---------------------------- libavfilter/colorspace.h | 31 +------- libavfilter/fflcms2.c | 33 +++++---- libavfilter/fflcms2.h | 4 +- libavfilter/vf_colorspace.c | 37 +++++----- libavfilter/vf_iccdetect.c | 5 +- libavfilter/vf_tonemap.c | 17 +---- libavutil/Makefile | 2 + libavutil/csp.c | 128 ++++++++++++++++++++++++++++++++ libavutil/csp.h | 115 +++++++++++++++++++++++++++++ libavutil/version.h | 2 +- 11 files changed, 326 insertions(+), 191 deletions(-) create mode 100644 libavutil/csp.c create mode 100644 libavutil/csp.h -- 2.36.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
