On Tue, May 26, 2015 at 09:45:28AM +0100, tim nicholson wrote: > On 24/05/15 02:15, Michael Niedermayer wrote: > > also store 1 for D10 > > > > Signed-off-by: Michael Niedermayer <michae...@gmx.at> > > --- > > libavformat/mxfenc.c | 11 +++++++++++ > > tests/ref/lavf/mxf | 6 +++--- > > tests/ref/lavf/mxf_d10 | 2 +- > > tests/ref/lavf/mxf_opatom | 2 +- > > tests/ref/lavf/mxf_opatom_audio | 2 +- > > 5 files changed, 17 insertions(+), 6 deletions(-) > > > > Do we want to make this an edge case for D10 muxing only, or should we > be aiming for it to be more universal?
i dont see how it can be made more universal in a way that has acceptable reliability > > Personally I try to avoid edge cases but I can see that trying to be > more universal could be difficult for a number of reasons in this case. > > If we keep this as an edge case perhaps the commit message should say so:- > > "Support storing signal standard for D10 muxing" ill add that thanks > > or some such. > (I can see a number of similar issues on the horizon too.) > > -- > Tim. > Key Fingerprint 38CF DB09 3ED0 F607 8B67 6CED 0C0B FC44 8B0B FC83 > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
