On 24.05.2015 18:56, Michael Niedermayer wrote: > On Sun, May 24, 2015 at 03:52:21PM +0200, Andreas Cadhalpun wrote: >> shine_encode_buffer expects written to be an int pointer, while the >> previous shine_encode_frame expected it to be a long pointer. >> >> Thus encoding with libshine currently always fails with >> "internal buffer too small", because a negative return value of >> shine_encode_buffer is interpreted as a very large long value. >> >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavcodec/libshine.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM, assuming that the type matches all libshine versions our > code can be built with
It does, because configure checks for shine_encode_buffer, which is only present since 3.0 and always expected it to be an int pointer. So pushed. Best regards, Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
