On Fri, 15 Apr 2022, Nil Admirari wrote:

---
fftools/Makefile         |  5 +++++
fftools/fftools.manifest | 10 ++++++++++
fftools/manifest.rc      |  3 +++
3 files changed, 18 insertions(+)
create mode 100644 fftools/fftools.manifest
create mode 100644 fftools/manifest.rc

I think the change here is fine, but the commit message absolutely needs to explain the full situation about what this does, how, etc.

As far as I've understood Windows long path support, it'd be something like this:

---8<---

Newer versions of Windows (Windows 10 1607 and newer) can support path names longer than MAX_PATH (260 characters). To take advantage of that, an application needs to opt in, by including a small manifest as a resource. Additionally, the path length limitation is only lifted for file APIs that pass paths as wchar_t. Therefore, the preceding patches have refactored a few remaining cases to internally open files with wchar_t path name functions.

On older versions of Windows, the newly added manifest has no effect.

---8<---

Does that sound like the correct explanation of the situation?

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to