On Wed, Apr 13, 2022 at 3:40 PM Marton Balint <c...@passwd.hu> wrote:
> > > On Wed, 13 Apr 2022, Martin Storsjö wrote: > > > On Mon, 11 Apr 2022, Tristan Matthews wrote: > > > >> This avoids having to do one pass to calculate the full length to > allocate > >> followed by a second pass to actually append values. > >> --- > >> libavformat/librtmp.c | 123 +++++++++++------------------------------- > >> 1 file changed, 32 insertions(+), 91 deletions(-) > > > > Thanks, this patch looks good to me. I'll wait for a little while still > if > > Marton wants to comment on it, before I go ahead and push it. > > According to commit 865461099e062de5a3a109c2a5be98004c11d8bd the buffer > passed to RTMP_SetupURL has to be kept as long as the RTMP context is > alive. > > Oh good catch, I should've dug deeper as to why ctx->temp_filename existed. Best, Tristan > Regards, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
