There is some bug on my mail application , when it open the .eml file , the space may be erase by the application, so the patch will not pass the test online
From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> on behalf of Nicolas George <geo...@nsup.org> Date: Tuesday, March 1, 2022 at 8:18 PM To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH] libavformat/concatdev.c: Add unified_time_base opt Ye Chuan (12022-03-01): > In some case, the input files have different time base even though > they share the same codec and codec parameters, > While processing the packet, it will adjust the pts/dts by its own > time base instead of the unified one of the output stream, which may > lead to wrong pts/dts or unexpected speed change. > > So this patch add the "unified_time_base" opt, which could be setted by > "-unified_time_base 1" > With the option, it will concatenate the input streams whose time base > are different , and won't course speed change issue. > > Signed-off-by: Chuan Ye <yechuan0...@hotmail.com> > --- > libavformat/concatdec.c | 31 ++++++++++++++++++++++++------- > 1 file changed, 24 insertions(+), 7 deletions(-) Thanks for the patch. I need to examine exactly what it does. In the meantime, I do not know why you keep posting new versions of this patch every few minutes. Please take your time. And before next time: > int segment_time_metadata; > + int unified_time_base; Mangled indentation. Missing documentation. Spelling mistake in the title of the commit message. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
