> 2022年2月28日 下午10:17,Michael Niedermayer <mich...@niedermayer.cc> 写道: > > On Mon, Feb 28, 2022 at 04:19:55PM +0800, 殷时友 wrote: >> >> >>> 2022年2月21日 下午11:00,Michael Niedermayer <mich...@niedermayer.cc> 写道: >>> >>> On Thu, Feb 17, 2022 at 07:11:47PM +0800, Hao Chen wrote: >>>> The loongson_intrinsics.h file is updated from v1.0.3 version >>>> to v1.1.0. Some spelling mistakes are fixed and new functions are added. >>>> >>>> Signed-off-by: Hao Chen <chen...@loongson.cn> >>>> --- >>>> libavutil/loongarch/loongson_intrinsics.h | 1697 +++++++++++---------- >>>> 1 file changed, 884 insertions(+), 813 deletions(-) >>>> >>>> diff --git a/libavutil/loongarch/loongson_intrinsics.h >>>> b/libavutil/loongarch/loongson_intrinsics.h >>>> index 6e0439f829..eb256863c8 100644 >>>> --- a/libavutil/loongarch/loongson_intrinsics.h >>>> +++ b/libavutil/loongarch/loongson_intrinsics.h >>>> @@ -33,7 +33,7 @@ >>>> * Xiwei Gu <guxiwei...@loongson.cn> >>>> * Lu Wang <wan...@loongson.cn> >>>> * >>>> - * This file is a header file for loongarch builtin extention. >>>> + * This file is a header file for loongarch builtin extension. >>>> * >>>> */ >>>> >>>> @@ -42,50 +42,50 @@ >>>> >>>> /** >>>> * MAJOR version: Macro usage changes. >>>> - * MINOR version: Add new functions, or bug fix. >>>> + * MINOR version: Add new functions, or bug fixes. >>>> * MICRO version: Comment changes or implementation changes. >>>> */ >>>> #define LSOM_VERSION_MAJOR 1 >>>> -#define LSOM_VERSION_MINOR 0 >>>> -#define LSOM_VERSION_MICRO 3 >>>> +#define LSOM_VERSION_MINOR 1 >>>> +#define LSOM_VERSION_MICRO 0 >>>> >>>> #define DUP2_ARG1(_INS, _IN0, _IN1, _OUT0, _OUT1) \ >>>> -{ \ >>>> - _OUT0 = _INS(_IN0); \ >>>> - _OUT1 = _INS(_IN1); \ >>>> -} >>>> + { \ >>>> + _OUT0 = _INS(_IN0); \ >>>> + _OUT1 = _INS(_IN1); \ >>>> + } >>>> >>>> #define DUP2_ARG2(_INS, _IN0, _IN1, _IN2, _IN3, _OUT0, _OUT1) \ >>>> -{ \ >>>> - _OUT0 = _INS(_IN0, _IN1); \ >>>> - _OUT1 = _INS(_IN2, _IN3); \ >>>> -} >>>> + { \ >>>> + _OUT0 = _INS(_IN0, _IN1); \ >>>> + _OUT1 = _INS(_IN2, _IN3); \ >>>> + } >>> >>> These style changes differ from the recommandition in doc/developer.texi >>> is that intentional ? >>> >>> thx >> >> >> Can we keep this style in here, it’s helpful for us to maintain this header >> file >> which used for some other projects too. Thanks very much. > > yes, it makes sense to keep the style under these circumstances >
Thanks, hope this patch set can be merged. It’s the last part of LoongArch avcodec optimization. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".