Andreas Rheinhardt: >> As the potential failure of the memory allocation, >> the avformat_new_stream() could return NULL pointer. >> Therefore, it should be better to check it and return >> error if fails. >> >> Fixes: 84ad31ff18 ("lavf: replace av_new_stream->avformat_new_stream part >> II.") > > This commit did not introduce this bug; it merely replaced the unchecked > function. > > If you look at nut_read_header() you will see that it just retries even > on allocation failure. So this is not a complete fix. And if it retries > and finds a different packet header, it adds ever more streams, because > the already created streams have not been deleted. A proper fix would > need to check the return value of decode_main_header for ENOMEM, but if > time_base_count were invalid and huge, one could get an allocation error > even though there might be a valid header somewhere else. So one would > need an equivalent of NUT_MAX_STREAMS for timebases or some other > criterion to rule this out.
Fine, I have submit a v2 to fix the problems above. Jiang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".