On Fri, 4 Feb 2022, Aman Karmani wrote:
From: Aman Karmani <a...@tmm1.net>
fixes #6578
Signed-off-by: Aman Karmani <a...@tmm1.net>
---
libavutil/arm/cpu.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
It would be good if the commit message actually explained the upsides to
doing this.
It's also important to point out that this function didn't use to exist in
all Android versions (hence the /proc/cpuinfo parsing). The point when the
function appeared (Android 4.4, API 20, according to the referenced trac
issue) is kinda far in the past today, but I'm not sure if strictly all
users of the library have stopped supporting older versions still - at
least for some use cases I've heard of recently, Android 4.1 was still
supported.
If coupled with a configure check for the function, so that users
explicitly targeting an older version that lack it wouldn't get it, I
guess this could be more easily acceptable.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
