Hi all, Is there anything I could do to kindly ask to review and accept the patch?
Best regards, Denis Shulyaka вт, 28 сент. 2021 г. в 17:53, Denis Shulyaka <shuly...@gmail.com>: > Hi all, > > This is a kind reminder. > > Best regards, > Denis Shulyaka > > вс, 11 апр. 2021 г. в 13:21, Denis Shulyaka <shuly...@gmail.com>: > >> Hi Carl, >> >> Thanks for the review. >> >> сб, 10 апр. 2021 г. в 18:05, Carl Eugen Hoyos <ceffm...@gmail.com>: >> >>> Please use "&" instead of "%". >>> >> >> Fixed >> >> Please remove this line. >>> >> >> Fixed >> >> See above. >>> >> >> Fixed >> >> Please remove this line or the default branch above. >>> >> >> Fixed. It was there as a safety feature in case someone adds a new >> condition to the switch which wouldn't return. >> >> Is this an unrelated fix? >>> >> >> Yes, you are right, will submit as a separate patch. >> >> > + if (!pkt_size) >>> > + return AVERROR_BUG; >>> >>> This looks wrong or do I miss something? >>> >> >> This is also just for safety to verify that future modifications of >> spdif_read_burst_payload_length() work correctly. Should I remove it? >> >> -- >> Best regards, >> Denis Shulyaka >> > > > -- > Best regards, > Denis Shulyaka > -- Best regards, Denis Shulyaka _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
