On Fri, Jan 7, 2022 at 11:20 AM Hendrik Leppkes <h.lepp...@gmail.com> wrote: > > On Fri, Jan 7, 2022 at 5:50 AM ffmpegagent <ffmpegag...@gmail.com> wrote: > > > > It's annoying and unexpected, but still useful at times (as I've realized > > just recently). > > > > This is a follow-up to the earlier submission here: > > https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html > > > > There has been a comment from Anton, questioning whether the dump-feature is > > useful. Meanwhile I came to the conclusion that it can be useful in-fact. It > > just shouldn't happen automatically when DEBUG is defined. That's what these > > patches do. > > > > I also added fixes for the fopen() call. > > > > softworkz (4): > > avcodec/dvbsubdec: don't dump images to disk based on DEBUG define > > avcodec/dvbsubdec: fix writing ppm > > avcodec/dvdsubdec: don't dump images to disk based on DEBUG define > > avcodec/dvdsubdec: fix writing ppm > > > > libavcodec/dvbsubdec.c | 20 +++++++++++++------- > > libavcodec/dvdsubdec.c | 11 ++++++++--- > > 2 files changed, 21 insertions(+), 10 deletions(-) > > > > > > These patches need some squasing. It should've been obvious from them > being duplicated. >
Actually I fell into the dvb dvd trap, but regardless the patches are basically identical, so I would still squash them, personally. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
