On Sun, Jan 2, 2022 at 6:22 PM Cameron Gutman <aicomman...@gmail.com> wrote:
> On 1/2/22 19:21, Aman Karmani wrote: > > > > > > On Sun, Jan 2, 2022 at 4:33 PM Cameron Gutman <aicomman...@gmail.com > <mailto:aicomman...@gmail.com>> wrote: > > > > Signed-off-by: Cameron Gutman <aicomman...@gmail.com <mailto: > aicomman...@gmail.com>> > > --- > > libavutil/hwcontext_videotoolbox.c | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/libavutil/hwcontext_videotoolbox.c > b/libavutil/hwcontext_videotoolbox.c > > index 0a8dbe9f33..026127d412 100644 > > --- a/libavutil/hwcontext_videotoolbox.c > > +++ b/libavutil/hwcontext_videotoolbox.c > > @@ -711,6 +711,30 @@ fail: > > return err; > > } > > > > +static int vt_map_from(AVHWFramesContext *hwfc, AVFrame *dst, > > + const AVFrame *src, int flags) > > +{ > > + int err; > > + > > + if (dst->format == AV_PIX_FMT_NONE) > > + dst->format = hwfc->sw_format; > > + else if (dst->format != hwfc->sw_format) > > + return AVERROR(ENOSYS); > > + > > + err = vt_map_frame(hwfc, dst, src, flags); > > + if (err) > > + return err; > > + > > + dst->width = src->width; > > + dst->height = src->height; > > + > > + err = av_frame_copy_props(dst, src); > > + if (err) > > + return err; > > + > > + return 0; > > +} > > + > > static int vt_device_create(AVHWDeviceContext *ctx, const char > *device, > > AVDictionary *opts, int flags) > > { > > @@ -736,6 +760,7 @@ const HWContextType > ff_hwcontext_type_videotoolbox = { > > .transfer_get_formats = vt_transfer_get_formats, > > .transfer_data_to = vt_transfer_data_to, > > .transfer_data_from = vt_transfer_data_from, > > + .map_from = vt_map_from, > > > > > > Thanks for this! > > > > Does this add support for hwdownload filter? Or what's the best way to > test this patch? > > > > Aman > > > > > > I'm calling the C API directly (av_hwframe_map) from my application, but > you can test it > with the command-line tool using something like this: > > ffmpeg -hwaccel videotoolbox -hwaccel_output_format videotoolbox_vld -i > 1280x720.h264 -vf "hwmap,format=nv12" 1280x720.yuv > > Replacing hwmap (which uses map_from) with hwdownload (which uses > transfer_data_from) > yields the same decoded YUV output, as expected. Thanks, I didn't realize hwmap used a different route. Patch applied to master. Aman > > > > Cam > > > > > .pix_fmts = (const enum AVPixelFormat[]){ > AV_PIX_FMT_VIDEOTOOLBOX, AV_PIX_FMT_NONE }, > > }; > > -- > > 2.25.1 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel < > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel> > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-requ...@ffmpeg.org <mailto: > ffmpeg-devel-requ...@ffmpeg.org> with subject "unsubscribe". > > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
