On Fri, 2021-12-24 at 16:17 +0800, lance.lmw...@gmail.com wrote: > On Fri, Dec 24, 2021 at 07:35:25AM +0000, Xiang, Haihao wrote: > > On Fri, 2021-08-06 at 10:10 +0800, Haihao Xiang wrote: > > > The SDK may insert picture timing SEI for hevc and the code to set mfx > > > parameter has been added in qsvenc, however the corresponding option is > > > missing in the hevc option array > > > --- > > > libavcodec/qsvenc_hevc.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > > > index b7b2f5633e..1e31968673 100644 > > > --- a/libavcodec/qsvenc_hevc.c > > > +++ b/libavcodec/qsvenc_hevc.c > > > @@ -248,6 +248,7 @@ static const AVOption options[] = { > > > { "tile_rows", "Number of rows for tiled > > > encoding", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 }, > > > 0, > > > UINT16_MAX, VE }, > > > { "recovery_point_sei", "Insert recovery point SEI > > > messages", OFFSET(qsv.recovery_point_sei), AV_OPT_TYPE_INT, { > > > .i64 > > > = -1 }, -1, 1, VE }, > > > { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud), > > > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE}, > > > + { "pic_timing_sei", "Insert picture timing SEI with > > > pic_struct_syntax > > > element", OFFSET(qsv.pic_timing_sei), AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, > > > VE > > It's better to use AV_OPT_TYPE_BOOL if the option is used for on/off or > enable/disable. >
Thanks for your comment. I'll change it to AV_OPT_TYPE_BOOL, > I think you need to add description in the doc for the new options if > possible. Currently there isn't a doc for qsv decoder, we'll try to add it later. Thanks Haihao > > > > }, > > > > > > { NULL }, > > > }; > > > > Will apply > > > > -Haihao > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".