Hi Michael, On Wed, Dec 15, 2021 at 3:52 PM Michael Niedermayer <mich...@niedermayer.cc> wrote: > > On Tue, Dec 14, 2021 at 05:42:01PM +0100, Diederick C. Niehorster wrote: > > Hi Michael, > > > > On Tue, Dec 14, 2021 at 5:19 PM Michael Niedermayer > > <mich...@niedermayer.cc> wrote: > > > > > > > > > The patches do not say in their commit messages that they have been > > > reviewed > > > maybe you want to repost them with that changed. > > > > Thanks for having a look! > > I have mentioned this here: > > https://ffmpeg.org/pipermail/ffmpeg-devel/2021-December/289461.html > > > > Or do you mean that for each specific patch, if there were previous > > review comments, i should mention that it was updated in response to > > the review? For some that may be hard (e.g. i was asked to change the > > order of some commits). > > Patches which where approved already and not changed since then could > contain that information in the commit message. We tend to use some > Reviewed-by: ... > for that > that may speed up future review and commit > > I dont know dshow and dont have a proper setup to test it so i wont be > applying or reviewing these patches
Ah, i see. I have made changes here in response to other review comment since i got that LGTM for the series. I'll contact the dshow maintainer again for that (I assume he would be the only one who should be committing my patchset?). Thanks, Dee _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
