On Sun, Dec 5, 2021 at 5:40 PM Lynne <d...@lynne.ee> wrote: > > + /** > > + * Usually the same as packet pts, in AV_TIME_BASE. > > + * > > + * @deprecated This is kept for compatibility reasons and corresponds > > to > > + * AVSubtitle->pts. Might be removed in the future. > > + */ > > + int64_t subtitle_pts; > > > > I'm not going to accept a field which is instantly deprecated. > As we've discussed multiple times, please merge this into > the regular frame PTS field. We already have _2_ necessary > stard/end fields. >
I agree with this entirely. Even ignoring the fact that adding a new field thats deprecated is instantly a disqualification, AVSubtitle had one pts field, AVFrame already has one pts field - both are even documented to have the same semantic. They should just contain the exact same data, thats how you achieve compatibility, not by claiming you need a new field for compatibility reasons. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
