On Fri, May 01, 2015 at 11:38:52AM +0200, Clément Bœsch wrote: > On Thu, Apr 30, 2015 at 02:45:12PM +0200, Michael Niedermayer wrote: > > On Thu, Apr 30, 2015 at 02:21:55PM +0200, Nicolas George wrote: > > > Le primidi 11 floréal, an CCXXIII, Michael Niedermayer a écrit : > > > > +@item object > > > > +Filepath of the object image, needs to be in gray8. > > > > + > > > > +@item cover > > > > +Filepath of the optional cover image, needs to be in yuv420. > > > > > > Suggestion: read object and cover (if enabled) from a second and third > > > input > > > to the filter. That way, format conversions, file reading, etc., is > > > already > > > taken care of. That also allows future enhancement, like having object > > > and/or cover evolve. > > > > > > Another suggestion: make the filter just "find", export the found > > > coordinates as metadata, and let overlay or delogo do the rest of the > > > work. > > > > These are good suggestions, do you and ubitux want to work on these? > > I'll pass, sorry.
ok, nicolas do you want to work on this ? if not, question is what is preferred apply the patch with all other review comments taken care of or not apply the patch that is wait for someone to extend dualinput to support >2 inputs some of which optional and update the filter to use it ? I think the split filter suggestion can easily be done later and would be more user friendly that way. That is we could just add a 3rd mode which does not change the frame but just exports metadata. That way the common use case requires just 1 filter while it still could export metadata in case theres some other filter which could do something with it Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
