On Thu, 25 Nov 2021, lance.lmw...@gmail.com wrote:

From: Limin Wang <lance.lmw...@gmail.com>

Signed-off-by: Limin Wang <lance.lmw...@gmail.com>
---
doc/protocols.texi     |  4 ++++
libavformat/rtpproto.c | 17 ++++++++++++++---
libavformat/rtsp.c     |  3 +++
libavformat/rtsp.h     |  1 +
4 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index a1aa969..3897826 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -74,6 +74,7 @@
#define COMMON_OPTS() \
    { "reorder_queue_size", "set number of packets to buffer for handling of 
reordered packets", OFFSET(reordering_queue_size), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 
INT_MAX, DEC }, \
    { "buffer_size",        "Underlying protocol send/receive buffer size",     
             OFFSET(buffer_size),           AV_OPT_TYPE_INT, { .i64 = -1 }, -1, INT_MAX, DEC|ENC }, 
\
+    { "localaddr",          "local address",                                   
              OFFSET(localaddr),             AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, DEC|ENC }, \
    { "pkt_size",           "Underlying protocol send packet size",             
             OFFSET(pkt_size),              AV_OPT_TYPE_INT, { .i64 = -1 }, -1, INT_MAX, ENC } \

As far as I can see, this is only used in sdp_read_header; wouldn't it be better to move this option to sdp_options then?

The rest of the patch seems fine I think.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to