On 2021-11-25 03:28 pm, Lynne wrote:
25 Nov 2021, 10:39 by jianhua...@intel.com:
Lynne:
From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of
Lynne
Sent: Thursday, November 25, 2021 5:33 PM
To: FFmpeg development discussions and patches <ffmpeg-
de...@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] avfilter: add a bflip_vulkan filter
25 Nov 2021, 10:22 by ffm...@gyani.pro:
On 2021-11-25 02:38 pm, Wu Jianhua wrote:
This filter flips the input video both horizontally and vertically in
one compute pipeline, and it's no need to use two pipelines for
hflip_vulkan,vflip_vulkan anymore.
bflip is not an intuitive name.
Either hvflip, or since h+v flip == 180 deg rotation, maybe rotate180
or rot180
Regards,
Gyan
I think I'd prefer if it was called 'transpose_vulkan', with the same options as
the regular transpose filter, but with only a single direction currently
supported.
That way, we'd have a template to which we could implement more modes
later on.
Does transpose only indicate switches the row and column indices? Ummm..I'm not
sure.
Maybe rotate 180 is more better.
You're right, transpose only does flips by 90 degrees.
I think you should just call it 'flip_vulkan' in this case.
That name indicates a generic filter with option to choose flip type. If
that's the plan, apt name, but else something specific is clearer.
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
