On Sun, Nov 21, 2021 at 02:58:35AM +0100, Andreas Rheinhardt wrote: > h263_get_motion_length() forgot to take an absolute value; > as a consequence, a negative index was used to access an array. > This leads to potential crashes, but mostly it just accesses what > is to the left of ff_mvtab (unless one uses ASAN), thereby defeating > the purpose of the AV_CODEC_FLAG2_NO_OUTPUT because the sizes of > the returned packets differ from the sizes the encoder would actually > have produced. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@outlook.com> > --- > Do we need this AV_CODEC_FLAG2_NO_OUTPUT codepath in h263.h and > mpeg4videoenc.c at all? It seems to have never worked and the speed > difference to encoding with output is negligible. (And I have not even > investigated whether the checks for whether said flag is set impact > the performance of ordinary encoding.)
For 2 pass encoding you dont need the data from the first pass just the amount. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Nations do behave wisely once they have exhausted all other alternatives. -- Abba Eban
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
