On Wed, 17 Nov 2021, J. Dekker wrote:

Signed-off-by: J. Dekker <j...@itanimul.li>
---
libavcodec/aarch64/hevcdsp_sao_neon.S | 195 ++++++++++++--------------
1 file changed, 90 insertions(+), 105 deletions(-)

Now matches the 9,25 indentation like other ASM.

No it doesn't.

This changes the indentation of the preexisting function, which was almost right into an even worse form. It still doesn't fix left-adjusting the operand columns as agreed upon before.

It doesn't fix the function added in patch 3/6 (and it shouldn't - you should fix that issue in that in that patch). It does fix the code added in patch 4/6 though, but that fix should be squashed into patch 4/6.

Ideally you'd reorder this patch first in the set, so you first fix the indentation of the preexisting code to be more consistent (keeping the instruction column alignment, left-adjusting the operand columns), then add more functions that all have consistent alignment from that point on.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to