On Tue, Nov 16, 2021 at 11:26:26PM +0100, Michael Niedermayer wrote: > On Tue, Nov 16, 2021 at 08:11:41PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-11-16 14:46:43) > > > On Mon, Nov 15, 2021 at 04:23:59PM +0100, Anton Khirnov wrote: > > > > bits_per_raw_sample is already set in new_video_stream(), so this code > > > > has no effect. > > > > --- > > > > fftools/ffmpeg.c | 7 ------- > > > > fftools/ffmpeg.h | 1 - > > > > fftools/ffmpeg_opt.c | 2 +- > > > > 3 files changed, 1 insertion(+), 9 deletions(-) > > > > > > maybe i messed up or missing something but this breaks fate for me > > > > Cannot reproduce here, FATE passes for me. > > Any ideas what could be the cause? > > id have to re-look but i think it only failed after a > make distclean > if it doesnt reproduce with make distclean then ill take a deeper > look (tomorrow or so)
ive just taken another quick look and simplified this down to whats causing it
heres a better testcase
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 7f9f98222f2..dc86c9859a2 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -3453,9 +3453,10 @@ static int init_output_stream_encode(OutputStream *ost,
AVFrame *frame)
enc_ctx->width != dec_ctx->width ||
enc_ctx->height != dec_ctx->height ||
enc_ctx->pix_fmt != dec_ctx->pix_fmt) {
- enc_ctx->bits_per_raw_sample = frame_bits_per_raw_sample;
+// enc_ctx->bits_per_raw_sample = frame_bits_per_raw_sample;
}
// Field order: autodetection
if (frame) {
if (enc_ctx->flags & (AV_CODEC_FLAG_INTERLACED_DCT |
AV_CODEC_FLAG_INTERLACED_ME) &&
with this:
ffmpeg -y -f image2 -c:v pgmyuv -i /tests/vsynth1/%02d.pgm -pix_fmt rgb48le
/tmp/%02d.rgb48le.dpx
Video encoding failed
Conversion failed!
(thats with the other patches in this set before this one applied) but no
other patches applied
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
