On Thu, Apr 30, 2015 at 04:22:23PM +0200, Jerome Martinez wrote:
> Le 30/04/2015 15:53, Michael Niedermayer a écrit :
> >On Thu, Apr 30, 2015 at 02:06:20PM +0200, Jerome Martinez wrote:
> >>Subject: [PATCH] Quantization tables syntax.
> >Add quantization tables syntax.
>
> Modified
>
> >
> >normally i dont care that much about formating but in a spec
> >consistent formating is important otherwise it looks unprofessional
> >so please make sure formating is consistent throughut the spec
> >further above there is QuantizationTable(i), that is without
> >the space
> >i think ite better without the space
>
> I tried to do that everywhere but I missed these ones.
> Fixed.
>
> >[...]
> >>+scale*=2*len_count[i][j]-1
> >missing spaces between operands and there are many more such
> >cases
>
> I deliberately reused the same formating than in the original
> specification, example:
> if(coder_type>1)
> No spaces between operands.
>
> Actually there are already some inconsistent formating. Example:
> if(version>2) {
> LyX Document
> if (colorspace_type == 1) {
> I only used the most common formating in the original spec.
>
> I propose to commit as is then I send a new patch with the formating.
> (with or without spaces between operands, as you prefer, but I
> prefer on my side not to mix e.g. "version>2" and "scale *= 2 *
> len_count[i][j] - 1", so I would reformat e.g. "version>2" to
> "version > 2" too)
>
> >>+context_count[i]=(scale+1)/2
> >is the rounding of the division operator defined somewhere ?
> >something like maybe refering to C for arithmetic operators
>
> Not for the moment.
> Explicit definition of operations is planned in a future dedicated patch.
>
> New patch attached (patch title, no space between function name and
> parameters).> ffv1.lyx | 1006 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 1002 insertions(+), 4 deletions(-) > 6c31eedc120a06e8575ccdeedc141dc49fb7c5cd > 0001-Add-quantization-tables-syntax.patch > From 929f3ea088fc52a7340c8b973cc422104863f4b4 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jer...@mediaarea.net> > Date: Thu, 30 Apr 2015 16:20:45 +0200 > Subject: [PATCH] Add quantization tables syntax. > > More details is provided about how to read quantization tables and the > associated values (context_count). > --- > ffv1.lyx | 1006 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 1002 insertions(+), 4 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the RIAA has been known to suggest that students drop out of college or go to community college in order to be able to afford settlements. -- The RIAA
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
