On Tue, 26 Oct 2021, J. Dekker wrote:

On 19 Oct 2021, at 10:40, Martin Storsjö wrote:

This one had the right indentation to start with, don't reindent it according to the new incorrectly indented code you're adding.

Yep. This was a mistake, some of (my) previously pushed code is actually incorrect here as well. Instructions should be indented to 9 Columns with the first argument being at 25 Columns.

You mentioned in the past about shifting the first argument left by 1 character when it began with a curly brace but I don't see this used in any other files (except the one added by me). Should this still be done?

I don't remember exactly what I've said, but as the rest of our source doesn't do that, I'd prefer if you'd avoid it too.

Also do you want a patch to reformat previous code to fit this 9,25 cols alignment?

Maybe yes, so there's less risk of confusion when writing new code.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to