Lynne: > 12 Sept 2021, 05:21 by softwo...@hotmail.com: > >> This is the root commit for adding subtitle filtering capabilities. >> Adding the media type property to AVFrame replaces the previous >> way of distinction which was based on checking width and height >> to determine whether a frame is audio or video. >> >> Signed-off-by: softworkz <softwo...@hotmail.com> >> > > Why do you need a new allocation function av_frame_get_buffer2 > when it has the same syntax as av_frame_get_buffer? > Also, could you please drop all but one of the filter patches > when sending new versions? You're overspamming the ML > and it's hard to keep up. > Finally, why not combine the 2 subtitle overlay filters into one? > There's no need for explicitness between text and bitmap subs.
Because they have different semantics: The new one checks allocates according to AVFrame.type, the old one according to the old semantics. That way a user unaware of the type field always doesn't get surprised. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
