> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of
> Soft Works
> Sent: Friday, 27 August 2021 05:14
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v3] fftools: Add option for writing
> detailed filtergraph information to file or stdout
>
> This is a more complete and more flexible alternative to the recently
> submitted
> patch "fftools: add -lavfi_dump option"
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210823094504.1007
> 89-2-geo...@nsup.org/
I'm submitting this updated version (fixes Fate) as I'm still convinced
that this is a better alternative to the patch referenced above.
What remains is the issue that this patch includes code that is duplicated
from ffprobe.c
The problem is that the code from ffprobe.c is not re-usable.
At this point I'd like to ask what is expected from me to do about it?
(for the hypothetical case that the patch would be agreeable)
Is it my responsibility to refactor the ffprobe code to make it re-usable?
- If no, what should I do?
- Wait until somebody does this (or in this case, e.g. Nicolas' code gets
merged)
(which would mean that it's impossible to submit the patch)
- Or can the patch with the duplicated be merged and the unification be done
later?
- If yes, in which order should it be done?
- Merge patch first and do the unification afterwards?
- Perform the ffprobe-refactoring as part of my patch?`
- Submit another patch first which does the ffprobe refactoring?
Thanks,
softworkz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
