On Sat, Aug 14, 2021 at 11:29:40 +0000, ffmpegandmahanstreamer@e.email wrote:
Just formal stuff:
> /* if macroblock width is 2, apply C-Y-C-Y; else
> * apply C-Y-Y */
> + APPLY_C_PREDICTOR();
> + APPLY_Y_PREDICTOR();
> + OUTPUT_PIXEL_PAIR();
> if (s->block_width == 2) {
Devs prefer that you omit the curly brackets, if the block only
contains one line. (I don't personally agree fully, but that doesn't
matter.)
> - OUTPUT_PIXEL_PAIR();
> + APPLY_C_PREDICTOR();
Indentation seems wrong.
> + OUTPUT_PIXEL_PAIR();
> break;
>
> +
> case 1:
You added an additional empty line.
As much as you praise the "graphical stuff" over the mailing list
approach: Was your graphical editor not capable of showing you these
issues? Hint: Review your commit (git diff before commit, git show
afterwards) before submitting it. (And whether "graphical stuff" is
greater or not, you would still have to correct errors by creating a
modified commit. And with github pull requests, you'd need to re-branch
or to force-push. Not much ease in the process there.)
Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
