On Wed, Aug 25, 2021 at 10:58 PM Martin Storsjö <mar...@martin.st> wrote:
>
> On Wed, 25 Aug 2021, Jan Ekström wrote:
>
> > subtitles.mak utilizes a more strict comparator and - to be honest -
> > the tests feel more at home in this location.
> > ---
>
> LGTM, although your commit message forgets to point out the relevant
> effect of it - we're not just doing this for sorting things in the most
> matching bucket, but because those tests were broken on Windows. Please
> mention that and mention that it was due to fate-sub-% getting
> CMP=rawdiff.
>

Thanks, applied with a better explanation part as
d48232fb4cdb55b3add08cef89c222a60d0896a9 .

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to