On Wed, Apr 22, 2015 at 12:24:40PM +0200, wm4 wrote: > These could be kept, but they are not overly useful. The only thing they > had over the remaining mp3 gapless test was seeking, which was incorrect > in the toc test, and only by chance correct in the notoc test. > --- > tests/fate/gapless.mak | 4 +--- > tests/ref/fate/gapless-mp3-notoc | 5 ----- > tests/ref/fate/gapless-mp3-toc | 5 ----- > 3 files changed, 1 insertion(+), 13 deletions(-) > delete mode 100644 tests/ref/fate/gapless-mp3-notoc > delete mode 100644 tests/ref/fate/gapless-mp3-toc
i suggest to keep the test which is correct even when its just by chance unless it breaks for a not easy correctable reason the test with wrong output should be removed, i agree [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
